eldenmoon commented on code in PR #15491:
URL: https://github.com/apache/doris/pull/15491#discussion_r1071703770
##########
fe/fe-core/src/main/cup/sql_parser.cup:
##########
@@ -6113,6 +6160,8 @@ literal ::=
{: RESULT = new BoolLiteral(false); :}
| KW_NULL
{: RESULT = new NullLiteral(); :}
+ | PLACEHOLDER
Review Comment:
represend the placeholder marker `?` , eg. `select * from tbl where a = ?`
##########
gensrc/proto/internal_service.proto:
##########
@@ -232,6 +232,38 @@ message PFetchDataResult {
optional bool empty_batch = 6;
};
+message KeyTuple {
+ repeated string key_column_rep = 1;
+}
+
+message UUID {
+ required int64 uuid_high = 1;
+ required int64 uuid_low = 2;
+}
+
+// We use thrift definition for some structure, since TExpr,
+// list<Exprs.TExpr>, Descriptors.TDescriptorTable are all thrift format.
+// Modify them to protobuf is a redundant work.
+message PTabletKeyLookupRequest {
+ required int64 tablet_id = 1;
+ repeated KeyTuple key_tuples = 2;
+
+ // reusable structures
+ // serilized from Descriptors.TDescriptorTable
+ optional UUID uuid = 3;
+ optional bytes desc_tbl = 4;
+ // serilized from TExprList
+ optional bytes output_expr = 5;
+ // return binary mysql row format if true
+ optional bool is_binary_row = 6;
+}
+
+message PTabletKeyLookupResponse {
+ required PStatus status = 1;
+ optional bytes row_batch = 5;
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
