wenzhenghu commented on code in PR #65126:
URL: https://github.com/apache/doris/pull/65126#discussion_r3680850069


##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/event/DropTableEvent.java:
##########
@@ -64,6 +65,10 @@ public static List<MetastoreEvent> 
getEvents(NotificationEvent event,
         return Lists.newArrayList(new DropTableEvent(event, catalogName));
     }
 
+    private static String normalizeTableName(String tableName) {
+        return tableName.toLowerCase(Locale.ROOT);

Review Comment:
   Fixed in `694268e500b`.
   
   `DropTableEvent` no longer lower-cases the HMS message table name before 
cleanup. The cache-only DROP path now keeps the original remote spelling 
through `CatalogMgr.unregisterExternalTable()`, so in 
`lower_case_table_names=2` it can still resolve and invalidate the exact local 
engine-cache key (for example `MixedTbl`) even when global object metadata TTL 
is `0` and only the engine entry remains hot.
   
   I also added FE UT coverage for this exact case in `ExternalCatalogTest`: 
mode 2, cold names/object/ID state, and a hot Hive engine schema entry keyed by 
the original mixed-case table name. `ExternalCatalogTest` passes locally after 
rebase; `mvn -pl fe-core -DskipTests checkstyle:check` and `git diff --check` 
also pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to