github-actions[bot] commented on PR #15972:
URL: https://github.com/apache/doris/pull/15972#issuecomment-1383653408
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/3928475232";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In thirdparty/build-thirdparty.sh line 1055:
if [ "$arch" == "avx512" ]; then
^---------------------^ SC2292 (style): Prefer [[ ]] over [ ] for
tests in Bash/Ksh.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
if [[ "${arch}" == "avx512" ]]; then
In thirdparty/build-thirdparty.sh line 1083:
elif [ "$arch" == "avx512" ]; then
^---------------------^ SC2292 (style): Prefer [[ ]] over [ ]
for tests in Bash/Ksh.
^---^ SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
elif [[ "${arch}" == "avx512" ]]; then
In thirdparty/build-thirdparty.sh line 1085:
"${DORIS_BIN_UTILS}/nm" --defined-only --extern-only $tmp_obj |
while read -r addr type sym ; do
^------^
SC2086 (info): Double quote to prevent globbing and word splitting.
^------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
"${DORIS_BIN_UTILS}/nm" --defined-only --extern-only "$tmp_obj"
| while read -r addr type sym ; do
In thirdparty/build-thirdparty.sh line 1086:
echo ${sym} ${sym}_${arch}
^----^ SC2086 (info): Double quote to prevent globbing
and word splitting.
^----^ SC2086 (info): Double quote to prevent
globbing and word splitting.
^-----^ SC2086 (info): Double quote to
prevent globbing and word splitting.
Did you mean:
echo "${sym}" "${sym}"_"${arch}"
In thirdparty/build-thirdparty.sh line 1088:
"${DORIS_BIN_UTILS}/objcopy" --redefine-syms=renames.txt
$tmp_obj $dst_obj
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer putting braces around variable references even
when not strictly required.
Did you mean:
"${DORIS_BIN_UTILS}/objcopy" --redefine-syms=renames.txt
"$tmp_obj" $dst_obj
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
https://www.shellcheck.net/wiki/SC2250 -- Prefer putting braces around
vari...
https://www.shellcheck.net/wiki/SC2292 -- Prefer [[ ]] over [ ] for tests
i...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -1052,8 +1052,8 @@
if [[ "${arch}" == "avx2" ]]; then
arch_flag="-mavx2"
fi
- if [ "$arch" == "avx512" ]; then
- arch_flag="-mavx512bw -mavx512f"
+ if [ "$arch" == "avx512" ]; then
+ arch_flag="-mavx512bw -mavx512f"
fi
tmp_obj="bitshuffle_${arch}_tmp.o"
dst_obj="bitshuffle_${arch}.o"
@@ -1082,9 +1082,9 @@
"${objcopy}" --redefine-syms=renames.txt "${tmp_obj}"
"${dst_obj}"
elif [ "$arch" == "avx512" ]; then
# Create a mapping file with '<old_sym> <suffixed_sym>' on each
line.
- "${DORIS_BIN_UTILS}/nm" --defined-only --extern-only $tmp_obj |
while read -r addr type sym ; do
+ "${DORIS_BIN_UTILS}/nm" --defined-only --extern-only $tmp_obj |
while read -r addr type sym; do
echo ${sym} ${sym}_${arch}
- done > renames.txt
+ done >renames.txt
"${DORIS_BIN_UTILS}/objcopy" --redefine-syms=renames.txt
$tmp_obj $dst_obj
else
mv "${tmp_obj}" "${dst_obj}"
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
