github-actions[bot] commented on code in PR #66097:
URL: https://github.com/apache/doris/pull/66097#discussion_r3655974422
##########
be/src/exec/operator/hashjoin_probe_operator.cpp:
##########
@@ -42,6 +43,7 @@ Status HashJoinProbeLocalState::init(RuntimeState* state,
LocalStateInfo& info)
SCOPED_TIMER(_init_timer);
_task_idx = info.task_idx;
auto& p = _parent->cast<HashJoinProbeOperatorX>();
+ custom_profile()->add_info_string("InstanceID",
print_id(state->fragment_instance_id()));
Review Comment:
[P2] Keep InstanceID on spill-enabled hash-join profiles
With `enable_spill` (or `enable_force_spill`) on a non-broadcast hash join,
`PipelineFragmentContext` reports the
`PartitionedHashJoinProbe`/`PartitionedHashJoinSink` wrappers instead. These
changed `HashJoin` states then exist only under private `internal_profile`
trees, and the wrappers copy selected counters but no info strings, so neither
user-visible build nor probe `CustomCounters` includes `InstanceID`—even when
the join never actually spills. Please add the ID to both outer partitioned
local states (or propagate it) so the advertised build/probe correlation works
on this supported path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
