Zmaul04 commented on code in PR #15158: URL: https://github.com/apache/doris/pull/15158#discussion_r1070159821
########## docs/en/docs/install/install-deploy.md: ########## @@ -226,7 +226,7 @@ See the `lower_case_table_names` section in [Variables](../../advanced/variables * BE webserver_port configuration Review Comment: src/Essentials/src/Connectivity/Connectivity.uwp.cs ########## docs/en/docs/data-table/data-model.md: ########## @@ -493,7 +493,7 @@ Therefore, when there are frequent count (*) queries in the business, we recomme Add a count column and import the data with the column value **equal to 1**. The result of `select count (*) from table;`is equivalent to `select sum (count) from table;` The query efficiency of the latter is much higher than that of the former. However, this method also has limitations, that is, users need to guarantee that they will not import rows with the same AGGREGATE KEY column repeatedly. Otherwise, `select sum (count) from table;`can only express the number of rows originally imported, not the semantics of `select count (*) from table;` -Another way is to **change the aggregation type of the count column above to REPLACE, and still weigh 1**. Then`select sum (count) from table;` and `select count (*) from table;` the results will be consistent. And in this way, there is no restriction on importing duplicate rows. +Another way is to **change the aggregation type of the count column above to REPLACE, and still weigh 1**. Then `select sum (count) from table;` and `select count (*) from table;` the results will be consistent. And in this way, there is no restriction on importing duplicate rows. Review Comment: ``` ``` ########## docs/en/docs/install/install-deploy.md: ########## @@ -226,7 +226,7 @@ See the `lower_case_table_names` section in [Variables](../../advanced/variables * BE webserver_port configuration - If the BE componet is installed in hadoop cluster, you need to change the configuration `webserver_port=8040` in be.conf to avoid port conflicts. + If the BE component is installed in hadoop cluster, you need to change configuration `webserver_port=8040` to avoid port used. Review Comment: @0xflotus ########## docs/en/docs/install/install-deploy.md: ########## @@ -226,7 +226,7 @@ See the `lower_case_table_names` section in [Variables](../../advanced/variables * BE webserver_port configuration - If the BE componet is installed in hadoop cluster, you need to change the configuration `webserver_port=8040` in be.conf to avoid port conflicts. + If the BE component is installed in hadoop cluster, you need to change configuration `webserver_port=8040` to avoid port used. * Set JAVA_HOME environment variable Review Comment: JavaScript ########## docs/en/docs/install/install-deploy.md: ########## @@ -226,7 +226,7 @@ See the `lower_case_table_names` section in [Variables](../../advanced/variables * BE webserver_port configuration Review Comment: - [ ] ########## docs/en/docs/data-table/data-model.md: ########## @@ -493,7 +493,7 @@ Therefore, when there are frequent count (*) queries in the business, we recomme Add a count column and import the data with the column value **equal to 1**. The result of `select count (*) from table;`is equivalent to `select sum (count) from table;` The query efficiency of the latter is much higher than that of the former. However, this method also has limitations, that is, users need to guarantee that they will not import rows with the same AGGREGATE KEY column repeatedly. Otherwise, `select sum (count) from table;`can only express the number of rows originally imported, not the semantics of `select count (*) from table;` -Another way is to **change the aggregation type of the count column above to REPLACE, and still weigh 1**. Then`select sum (count) from table;` and `select count (*) from table;` the results will be consistent. And in this way, there is no restriction on importing duplicate rows. +Another way is to **change the aggregation type of the count column above to REPLACE, and still weigh 1**. Then `select sum (count) from table;` and `select count (*) from table;` the results will be consistent. And in this way, there is no restriction on importing duplicate rows. Review Comment: **__ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
