yiguolei commented on code in PR #15917: URL: https://github.com/apache/doris/pull/15917#discussion_r1069483554
########## be/src/olap/schema.h: ########## @@ -144,6 +144,7 @@ class Schema { const std::vector<ColumnId>& column_ids() const { return _col_ids; } const std::vector<int32_t>& unique_ids() const { return _unique_ids; } ColumnId column_id(size_t index) const { return _col_ids[index]; } + ColumnId column_id(const std::string& cname) const { return _field_name_to_col_id.at(cname); } Review Comment: why need column name here? column name is not right during light weight schema change. For example, user call alter table rename column -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org