morningman commented on PR #65778: URL: https://github.com/apache/doris/pull/65778#issuecomment-5055951730
hi @arpitjain099 , this modification may change some behavior, if user already use previous format to match something. you can see several test cases failed like: ``` Exception: java.lang.IllegalStateException: Check tag 'show_data_sql_1024g' failed: Check tag 'show_data_sql_1024g' failed, line 2, CHAR result mismatch. Expect cell is: 1024.000 GB But real is : 1.000 TB line 2 mismatch ExpectRow: [Quota, 1024.000 GB, 1073741824, , ] RealRow : [Quota, 1.000 TB, 1073741824, , ] ``` So I suggest not change it, although it is inconsistent with `getUint`, but not a very big deal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
