github-actions[bot] commented on code in PR #15853:
URL: https://github.com/apache/doris/pull/15853#discussion_r1067683936
##########
be/test/runtime/test_env.cc:
##########
@@ -34,8 +33,6 @@ TestEnv::TestEnv() {
// Some code will use ExecEnv::GetInstance(), so init the global ExecEnv
singleton
_exec_env = ExecEnv::GetInstance();
_exec_env->_thread_mgr = new ThreadResourceMgr(2);
Review Comment:
warning: '_thread_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_exec_env->_thread_mgr = new ThreadResourceMgr(2);
^
```
**be/src/runtime/exec_env.h:208:** declared private here
```cpp
ThreadResourceMgr* _thread_mgr = nullptr;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -50,14 +47,8 @@
DCHECK(st.ok()) << st;
}
-void TestEnv::init_buffer_pool(int64_t min_page_len, int64_t capacity, int64_t
clean_pages_limit) {
- _exec_env->_buffer_pool = new BufferPool(min_page_len, capacity,
clean_pages_limit);
-}
-
TestEnv::~TestEnv() {
SAFE_DELETE(_exec_env->_result_queue_mgr);
- SAFE_DELETE(_exec_env->_buffer_pool);
- SAFE_DELETE(_exec_env->_disk_io_mgr);
SAFE_DELETE(_exec_env->_thread_mgr);
if (_engine == StorageEngine::_s_instance) {
Review Comment:
warning: '_s_instance' is a private member of 'doris::StorageEngine'
[clang-diagnostic-error]
```cpp
if (_engine == StorageEngine::_s_instance) {
^
```
**be/src/olap/storage_engine.h:321:** declared private here
```cpp
d;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -34,8 +33,6 @@
// Some code will use ExecEnv::GetInstance(), so init the global ExecEnv
singleton
_exec_env = ExecEnv::GetInstance();
_exec_env->_thread_mgr = new ThreadResourceMgr(2);
- _exec_env->_disk_io_mgr = new DiskIoMgr(1, 1, 1, 10);
- _exec_env->disk_io_mgr()->init(-1);
_exec_env->_result_queue_mgr = new ResultQueueMgr();
Review Comment:
warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
_exec_env->_result_queue_mgr = new ResultQueueMgr();
^
```
**be/src/runtime/exec_env.h:204:** declared private here
```cpp
ResultQueueMgr* _result_queue_mgr = nullptr;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -50,14 +47,8 @@
DCHECK(st.ok()) << st;
}
-void TestEnv::init_buffer_pool(int64_t min_page_len, int64_t capacity, int64_t
clean_pages_limit) {
- _exec_env->_buffer_pool = new BufferPool(min_page_len, capacity,
clean_pages_limit);
-}
-
TestEnv::~TestEnv() {
SAFE_DELETE(_exec_env->_result_queue_mgr);
- SAFE_DELETE(_exec_env->_buffer_pool);
- SAFE_DELETE(_exec_env->_disk_io_mgr);
SAFE_DELETE(_exec_env->_thread_mgr);
Review Comment:
warning: '_thread_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
SAFE_DELETE(_exec_env->_thread_mgr);
^
```
**be/src/runtime/exec_env.h:208:** declared private here
```cpp
ThreadResourceMgr* _thread_mgr = nullptr;
^
```
##########
be/test/runtime/test_env.cc:
##########
@@ -50,14 +47,8 @@
DCHECK(st.ok()) << st;
}
-void TestEnv::init_buffer_pool(int64_t min_page_len, int64_t capacity, int64_t
clean_pages_limit) {
- _exec_env->_buffer_pool = new BufferPool(min_page_len, capacity,
clean_pages_limit);
-}
-
TestEnv::~TestEnv() {
SAFE_DELETE(_exec_env->_result_queue_mgr);
Review Comment:
warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv'
[clang-diagnostic-error]
```cpp
SAFE_DELETE(_exec_env->_result_queue_mgr);
^
```
**be/src/runtime/exec_env.h:204:** declared private here
```cpp
ResultQueueMgr* _result_queue_mgr = nullptr;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
