github-actions[bot] commented on code in PR #15832:
URL: https://github.com/apache/doris/pull/15832#discussion_r1066886506
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -866,6 +874,8 @@
if (a._in_restore_mode != b._in_restore_mode) return false;
if (a._preferred_rowset_type != b._preferred_rowset_type) return false;
if (a._storage_policy != b._storage_policy) return false;
+ if (a._cooldown_replica_id != b._cooldown_replica_id) return false;
+ if (a._cooldown_term != b._cooldown_term) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (a._cooldown_term != b._cooldown_term) { return false;
}
```
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -866,6 +874,8 @@ bool operator==(const TabletMeta& a, const TabletMeta& b) {
if (a._in_restore_mode != b._in_restore_mode) return false;
if (a._preferred_rowset_type != b._preferred_rowset_type) return false;
if (a._storage_policy != b._storage_policy) return false;
+ if (a._cooldown_replica_id != b._cooldown_replica_id) return false;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (a._cooldown_replica_id != b._cooldown_replica_id) { return false;
}
```
##########
be/test/io/cache/remote_file_cache_test.cpp:
##########
@@ -141,7 +141,11 @@ class RemoteFileCacheTest : public ::testing::Test {
EXPECT_NE("", writer.min_encoded_key().to_string());
EXPECT_NE("", writer.max_encoded_key().to_string());
- st = segment_v2::Segment::open(fs, path, 0, {}, query_schema, res);
+
+ io::FileReaderOptions
reader_options(io::cache_type_from_string(config::file_cache_type),
+ io::SegmentCachePathPolicy());
+ reader_options.path_policy.cache_path = segment_cache_path(seg_id);
Review Comment:
warning: use of undeclared identifier 'seg_id' [clang-diagnostic-error]
```cpp
reader_options.path_policy.cache_path = segment_cache_path(seg_id);
^
```
##########
be/test/tools/benchmark_tool.cpp:
##########
@@ -363,7 +363,10 @@
writer.finalize(&file_size, &index_size);
file_writer->close();
- Segment::open(fs, path, "", seg_id, {}, &_tablet_schema, res);
+ io::FileReaderOptions
reader_options(io::cache_type_from_string(config::file_cache_type),
+ io::SegmentCachePathPolicy());
+ reader_options.path_policy.cache_path = segment_cache_path(seg_id);
+ Segment::open(fs, path, "", seg_id, {}, &_tablet_schema,
reader_options, res);
Review Comment:
warning: too many arguments to function call, expected 7, have 8
[clang-diagnostic-error]
```cpp
Segment::open(fs, path, "", seg_id, {}, &_tablet_schema,
reader_options, res);
^
```
**be/src/olap/rowset/segment_v2/segment.h:63:** 'open' declared here
```cpp
static Status open(io::FileSystemSPtr fs, const std::string& path,
uint32_t segment_id,
^
```
##########
be/test/tools/benchmark_tool.cpp:
##########
@@ -363,7 +363,10 @@ class SegmentBenchmark : public BaseBenchmark {
writer.finalize(&file_size, &index_size);
file_writer->close();
- Segment::open(fs, path, "", seg_id, {}, &_tablet_schema, res);
+ io::FileReaderOptions
reader_options(io::cache_type_from_string(config::file_cache_type),
+ io::SegmentCachePathPolicy());
+ reader_options.path_policy.cache_path = segment_cache_path(seg_id);
Review Comment:
warning: use of undeclared identifier 'segment_cache_path'
[clang-diagnostic-error]
```cpp
reader_options.path_policy.cache_path = segment_cache_path(seg_id);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
