github-actions[bot] commented on code in PR #65468:
URL: https://github.com/apache/doris/pull/65468#discussion_r3568703890
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -318,28 +317,31 @@ public LogicalOlapTableStreamScan
withRelationId(RelationId relationId) {
hints, cacheSlotWithSlotName, cachedOutput,
tableSample, directMvScan, colToSubPathsMap,
manuallySpecifiedTabletIds, operativeSlots,
virtualColumns, scoreOrderKeys, scoreLimit,
scoreRangeInfo, annOrderKeys, annLimit, tableAlias,
partitionPrunablePredicates,
- scanParams, isReset, isSnapshot));
+ scanParams, readMode));
}
- /**
- * withIsSnapshot
- */
- public LogicalOlapTableStreamScan withIsSnapshot(boolean isSnapshot) {
+ @Override
Review Comment:
`LogicalSubQueryAliasToLogicalProject` rewrites `FROM stream AS s` by
calling `withTableAlias(alias)` on the child before this new
stream-normalization batch runs. This class now preserves `readMode` in the
explicit stream copy methods, but it still inherits
`LogicalOlapScan.withTableAlias`, which constructs a plain `LogicalOlapScan`.
Once that happens, `NormalizeOlapTableStreamScan` no longer matches and
`getStreamReadMode()` falls back to empty, so aliased streams, including
`stream@reset() AS s`, can lose the stream lowering/read mode. Please add a
`withTableAlias` override here that returns `LogicalOlapTableStreamScan` and
preserves the same fields/readMode as the other copy methods, with an
aliased-stream regression case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
