ByteYue commented on code in PR #15762:
URL: https://github.com/apache/doris/pull/15762#discussion_r1065387585
##########
be/src/olap/predicate_creator.h:
##########
@@ -163,6 +166,9 @@ inline std::unique_ptr<PredicateCreator<ConditionType>>
get_creator(const FieldT
case OLAP_FIELD_TYPE_LARGEINT: {
return std::make_unique<IntegerPredicateCreator<TYPE_LARGEINT, PT,
ConditionType>>();
}
+ case OLAP_FIELD_TYPE_DOUBLE: {
Review Comment:
>
> Better remove DoulbePredicatrCreator and use IntegerPredicateCreator
directly on `DOUBLE`.
OK. Already changed.
>btw `DoulbePredicatrCreator` seems have a typo. XD
😂Oh... My bad. I didn't notice it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
