Gabriel39 commented on code in PR #65446:
URL: https://github.com/apache/doris/pull/65446#discussion_r3567949401
##########
be/src/format/parquet/vparquet_reader.cpp:
##########
@@ -1305,6 +1322,9 @@ Status ParquetReader::_process_page_index_filter(
const auto& page_locations = offset_index.page_locations;
sig_stat.col_schema = col_schema;
+ cached_page_index.ctz = col_schema->parquet_schema.type ==
tparquet::Type::INT96
Review Comment:
Resolved by narrowing the scope to scanner v2. All legacy v1 Parquet reader
and page-index changes have been removed; the affected v1 files now match .
##########
be/src/core/data_type_serde/data_type_serde.cpp:
##########
@@ -493,8 +511,10 @@ Status decode_timestamp_orc_values(IColumn& nested_column,
const OrcDecodedColum
}
auto& value =
reinterpret_cast<DateV2Value<DateTimeV2ValueType>&>(data[old_data_size + row]);
- value.from_unixtime(orc_batch->data[source_row], timezone);
-
value.set_microsecond(cast_set<uint64_t>(orc_batch->nanoseconds[source_row] /
1000));
+ const auto timestamp = round_orc_timestamp_to_microseconds(
Review Comment:
The intended scope is scanner v2 only, so v1/v2 parity is not required here.
All legacy v1 Parquet changes were removed in 79a3057424a; the ORC and Parquet
compatibility behavior remains confined to format_v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
