adonis0147 commented on code in PR #15661:
URL: https://github.com/apache/doris/pull/15661#discussion_r1065315916
##########
thirdparty/build-thirdparty.sh:
##########
@@ -681,7 +681,7 @@ build_hyperscan() {
mkdir -p "${BUILD_DIR}"
cd "${BUILD_DIR}"
- "${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=0 \
+ "${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=0
-DCMAKE_BUILD_TYPE=RELWITHDEBINFO \
Review Comment:
```suggestion
"${CMAKE_CMD}" -G "${GENERATOR}" -DBUILD_SHARED_LIBS=0
-DCMAKE_BUILD_TYPE=RelWithDebInfo \
```
Reference:
```shell
~ cmake --help-variable CMAKE_BUILD_TYPE
CMAKE_BUILD_TYPE
----------------
Specifies the build type on single-configuration generators (e.g.
:ref:`Makefile Generators` or ``Ninja``). Typical values include
``Debug``, ``Release``, ``RelWithDebInfo`` and ``MinSizeRel``, but custom
build types can also be defined.
This variable is initialized by the first ``project()`` or
``enable_language()`` command called in a project when a new build
tree is first created. If the ``CMAKE_BUILD_TYPE`` environment
variable is set, its value is used. Otherwise, a toolchain-specific
default is chosen when a language is enabled. The default value is often
an empty string, but this is usually not desirable and one of the other
standard build types is usually more appropriate.
Depending on the situation, the value of this variable may be treated
case-sensitively or case-insensitively. See :ref:`Build Configurations`
for discussion of this and other related topics.
For multi-config generators, see ``CMAKE_CONFIGURATION_TYPES``.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
