github-actions[bot] commented on code in PR #65492: URL: https://github.com/apache/doris/pull/65492#discussion_r3565733245
########## be/test/storage/key/row_key_encoder_test.cpp: ########## @@ -0,0 +1,637 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +// The test builds TabletSchema/TabletColumn objects field by field, the same +// way the existing storage unit tests do (tablet_schema_helper.cpp does the same). +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wkeyword-macro" +#define private public Review Comment: The `private`/`protected` macros should be scoped to only the headers that need white-box access. Right now they remain defined for every later include and declaration in this translation unit, so gtest, standard-library headers, and the other Doris headers are all parsed with their access specifiers rewritten to `public`. Nearby white-box tests such as `segment_iterator_limit_opt_test.cpp` include the target header under the macros and immediately `#undef` both names afterward. Please do the same here before including gtest/standard/Doris headers so the access-specifier rewrite only affects the intended Doris test target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
