hutiefang76 opened a new pull request, #65484:
URL: https://github.com/apache/doris/pull/65484
### What problem does this PR solve?
Issue Number: close #65383
Related PR: None
Problem Summary:
`ALTER TABLE ... SET ('binlog.format'=...)` was not recognized as a binlog
configuration update. It fell through to the generic schema-change path and
returned the ROW-binlog schema-change error before the existing
immutable-format validation could run.
This change routes `binlog.format` through `updateBinlogConfig()`, where
`BinlogConfig.mergeFromProperties(..., false)` already returns the specific
unsupported format-change error.
### Release note
Unsupported `binlog.format` changes now report the immutable binlog-format
error instead of the generic ROW schema-change error.
### Check List (For Author)
- Test
- [ ] Regression test
- [x] Unit Test
- `AlterOperationsTest`
- `SchemaChangeHandlerTest#testChangeBinlogFormatReportsBinlogError`
- `./build.sh --fe`
- [ ] Manual test
- [ ] No need to test or manual test.
- Behavior changed:
- [ ] No.
- [x] Yes. Only the error reported for unsupported `binlog.format`
changes is corrected.
- Does this need documentation?
- [x] No.
- [ ] Yes.
I used AI-assisted review during development. I verified the root cause,
patch, tests, and build locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
