github-actions[bot] commented on code in PR #64038:
URL: https://github.com/apache/doris/pull/64038#discussion_r3564189419
##########
common/cpp/obj_retry_strategy.cpp:
##########
@@ -65,6 +78,10 @@ std::unique_ptr<Azure::Core::Http::RawResponse>
AzureRetryRecordPolicy::Send(
static_cast<int>(response->GetStatusCode()) < 200) {
if (retry_count > 0) {
object_request_retry_count << 1;
Review Comment:
This still misses the common Azure throttling case where the first attempt
returns 429 and the SDK retry succeeds. `AzureRetryRecordPolicy` is installed
in `PerRetryPolicies`, which run downstream of `RetryPolicy` for each attempt;
on the first 429 response, `GetRetryCount(context)` is still 0, so this `if
(retry_count > 0)` block does not increment
`s3_request_retry_too_many_requests_count`. If the next attempt succeeds, no
later non-2xx response passes through this block, so the new 429 retry metric
stays flat while S3 increments it from `ShouldRetry` on the first retryable
429. Please record the 429 before this retry-count gate, or otherwise hook the
Azure retry decision path, so successful retries after an initial 429 are
counted consistently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
