HappenLee commented on code in PR #65300:
URL: https://github.com/apache/doris/pull/65300#discussion_r3557269004
##########
be/src/exec/operator/join/process_hash_table_probe_impl.h:
##########
@@ -154,12 +154,47 @@ void
ProcessHashTableProbe<JoinOpType>::build_side_output_column(MutableColumns&
}
}
+template <int JoinOpType>
Review Comment:
你这里应该把所有all_match_one相关的函数和参数改成 is_contiguous_probe_indices ，这个名字取成all match
one, 太抽象了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
