github-actions[bot] commented on code in PR #65373:
URL: https://github.com/apache/doris/pull/65373#discussion_r3556883638
##########
regression-test/plugins/plugin_compaction.groovy:
##########
@@ -87,6 +87,27 @@ Suite.metaClass.trigger_and_wait_compaction = { String
table_name, String compac
def tabletStatus = parseJson(stdout.trim())
be_tablet_compaction_status.put("${be_host}-${tablet.TabletId}",
tabletStatus)
}
+ def isIgnoredCompactionStatus = { status ->
+ def status_lower = "${status}".toLowerCase()
+ return ignored_errors.any { error ->
status_lower.contains(error.toLowerCase()) }
+ }
+ def isNoopCompactionStatus = { type, status ->
+ def status_lower = "${status}".toLowerCase()
+ switch (type) {
+ case "full":
+ return status_lower.contains("no suitable version") ||
+ status_lower.contains("e-808") ||
+ status_lower.contains("e-2008")
+ case "cumulative":
+ return status_lower.contains("e-2000")
+ case "binlog":
Review Comment:
This classifies every cumulative `E-2000` as a no-op, but in cloud mode
`E-2000` is also used for meta-service job conflicts. The manual cloud endpoint
returns `Success` after queuing `_submit_cumulative_compaction_task()`, and the
worker later calls `_request_tablet_global_compaction_lock()`. If
`prepare_tablet_job()` returns `JOB_TABLET_BUSY`,
`CloudCumulativeCompaction::request_global_lock()` turns it into
`CUMULATIVE_NO_SUITABLE_VERSION` with `"cumu no suitable versions: job tablet
busy"`; with this PR the lock-failure path records that status and a fresh
failure time. Then once `/run_status` is false, both helper branches can treat
it as `compactionFailureNonFatal` and finish even though no compaction ran.
Please exclude the `job tablet busy`/global-lock-conflict form of cumulative
`E-2000` from no-op completion; keep polling or fail it, and only suppress the
actual no-input/no-picked-rowset cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
