github-actions[bot] commented on code in PR #65373:
URL: https://github.com/apache/doris/pull/65373#discussion_r3556242401
##########
regression-test/plugins/plugin_compaction.groovy:
##########
@@ -177,9 +192,28 @@ Suite.metaClass.trigger_and_wait_compaction = { String
table_name, String compac
}
def success_time_unchanged = (oldStatus["last
${compaction_type} success time"] == tabletStatus["last ${compaction_type}
success time"])
def failure_time_unchanged = (oldStatus["last
${compaction_type} failure time"] == tabletStatus["last ${compaction_type}
failure time"])
- def currentCompactionTimestampChanged =
!success_time_unchanged || !failure_time_unchanged
+ def compactionFailureNonFatal = !failure_time_unchanged &&
Review Comment:
This still needs to prove that the status belongs to the same attempt whose
failure timestamp changed. In cloud full compaction, an earlier no-suitable
prepare failure leaves `last full status` as `E-808`/no suitable, but a later
manual full compaction can pass prepare and then fail in
`CloudFullCompaction::request_global_lock()`. That failure path only updates
`last full failure time` in `_request_tablet_global_compaction_lock()`; it does
not refresh `last full status` because `execute_compact()` never runs. The
helper will then see a new failure timestamp plus the stale no-op status, set
`compactionFailureNonFatal`, and finish as if the requested compaction
completed benignly. Please only suppress no-op/ignored failures when the status
is known to be from the same failure event, or make every failure-time update
refresh the matching status first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
