yujun777 commented on code in PR #65438:
URL: https://github.com/apache/doris/pull/65438#discussion_r3556227386
##########
fe/fe-catalog/src/main/java/org/apache/doris/catalog/Column.java:
##########
@@ -101,6 +101,11 @@ public static Column generateAfterValueColumn(Column
column) {
Column afterValueColumn = new Column(column);
afterValueColumn.setComment("after value (" + column.getName() + ")");
afterValueColumn.setAggregationType(AggregateType.NONE, true);
+ afterValueColumn.setIsAllowNull(true);
Review Comment:
Thanks, the technical point is valid for persisted legacy row-binlog
metadata.
For the current stage, row binlog / Table Stream is still under active
development on master only and is not GA or opened for general users yet. We do
not currently treat previously persisted experimental row-binlog metadata as an
upgrade-compatibility contract.
Because of that, the scope of this PR is intentionally limited to the
forward path: newly generated row-binlog schemas (and regenerated schemas on
add-column paths) should no longer produce the non-null after-value slot that
can crash BE for MIN_DELTA before rows.
If we later decide to guarantee compatibility for legacy experimental
row-binlog metadata across restart/upgrade, we can add a dedicated load-time
normalization step separately. For this stage, we prefer to keep this fix
focused on the active development path and the crash it reproduces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
