This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-4.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-4.1 by this push:
new a7d5c4532c9 branch-4.1: [fix](ut) stabilize AlterMTMVTest (#65384)
a7d5c4532c9 is described below
commit a7d5c4532c94c8ef080624f4c0b139a6fc18ae61
Author: shuke <[email protected]>
AuthorDate: Fri Jul 10 09:36:09 2026 +0800
branch-4.1: [fix](ut) stabilize AlterMTMVTest (#65384)
### What problem does this PR solve?
Backport the AlterMTMVTest deflake from #56997 to branch-4.1.
On branch-4.1, `testAlterMTMV` creates an MTMV with `BUILD IMMEDIATE`
and then asserts the rename result through `getCandidateMTMVs()`.
Candidate collection depends on refresh/candidate-ready state, so the
test can observe a legal intermediate state before the async refresh
path has finished.
The test intent here is to verify that the MTMV relation mapping is
updated after renaming `mv_a` to `mv_b`, and that an MTMV cannot be used
as the replacement target for `ALTER TABLE ... REPLACE WITH TABLE`.
### What is changed?
Use the same shape as the master-side fix in #56997:
- create the MTMV with `BUILD DEFERRED`
- assert the relation mapping through `getMtmvsByBaseTable(...)`
- keep the original rename and replace-table assertions
### Check List
- [x] `git diff --check`
- [x] `./run-fe-ut.sh --run org.apache.doris.mtmv.AlterMTMVTest` reached
`Tests run: 1, Failures: 0, Errors: 0`; the remaining Maven reactor was
interrupted after the target test per local handoff decision
Related: DORIS-26807
---
.../test/java/org/apache/doris/mtmv/AlterMTMVTest.java | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/fe/fe-core/src/test/java/org/apache/doris/mtmv/AlterMTMVTest.java
b/fe/fe-core/src/test/java/org/apache/doris/mtmv/AlterMTMVTest.java
index 342f9fd60c8..60e7d28998f 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/mtmv/AlterMTMVTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/mtmv/AlterMTMVTest.java
@@ -18,12 +18,10 @@
package org.apache.doris.mtmv;
import org.apache.doris.catalog.Env;
-import org.apache.doris.catalog.MTMV;
import org.apache.doris.catalog.Table;
import org.apache.doris.common.DdlException;
import org.apache.doris.utframe.TestWithFeService;
-import com.google.common.collect.Lists;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
@@ -42,7 +40,7 @@ public class AlterMTMVTest extends TestWithFeService {
+ "DISTRIBUTED BY HASH(`sid`) BUCKETS 1\n"
+ "PROPERTIES ('replication_allocation' =
'tag.location.default: 1')");
- createMvByNereids("CREATE MATERIALIZED VIEW mv_a BUILD IMMEDIATE
REFRESH COMPLETE ON COMMIT\n"
+ createMvByNereids("CREATE MATERIALIZED VIEW mv_a BUILD DEFERRED
REFRESH COMPLETE ON COMMIT\n"
+ "DISTRIBUTED BY HASH(`sid`) BUCKETS 1\n"
+ "PROPERTIES ('replication_allocation' =
'tag.location.default: 1') "
+ "AS select * from stu limit 1");
@@ -51,14 +49,14 @@ public class AlterMTMVTest extends TestWithFeService {
MTMVRelationManager relationManager =
Env.getCurrentEnv().getMtmvService().getRelationManager();
Table table =
Env.getCurrentInternalCatalog().getDb("test").get().getTableOrMetaException("stu");
- Set<MTMV> allMTMVs =
relationManager.getCandidateMTMVs(Lists.newArrayList(new BaseTableInfo(table)));
+ Set<BaseTableInfo> allMTMVs = relationManager.getMtmvsByBaseTable(new
BaseTableInfo(table));
boolean hasMvA = false;
boolean hasMvB = false;
- for (MTMV mtmv : allMTMVs) {
- if ("mv_a".equals(mtmv.getName())) {
+ for (BaseTableInfo mtmv : allMTMVs) {
+ if ("mv_a".equals(mtmv.getTableName())) {
hasMvA = true;
}
- if ("mv_b".equals(mtmv.getName())) {
+ if ("mv_b".equals(mtmv.getTableName())) {
hasMvB = true;
}
}
@@ -74,6 +72,7 @@ public class AlterMTMVTest extends TestWithFeService {
DdlException exception = Assertions.assertThrows(DdlException.class,
() ->
alterTableSync("ALTER TABLE stu1 REPLACE WITH TABLE mv_b
PROPERTIES('swap' = 'true')"));
- Assertions.assertEquals("errCode = 2, detailMessage = replace
table[mv_b] cannot be a materialized view", exception.getMessage());
+ Assertions.assertEquals("errCode = 2, detailMessage = replace
table[mv_b] cannot be a materialized view",
+ exception.getMessage());
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
