github-actions[bot] commented on code in PR #64929: URL: https://github.com/apache/doris/pull/64929#discussion_r3552361851
########## extension/dbt-doris/dev-requirements.txt: ########## @@ -17,7 +17,7 @@ # install latest changes in dbt-core git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core Review Comment: This still leaves the fresh `pip install -r extension/dbt-doris/dev-requirements.txt` path broken. The PR fixes the `dbt-tests-adapter` URL, but pip fails earlier on this line because current `dbt-labs/dbt-core` `main` no longer has a `core` Python project (`/core` 404s and the dry-run reports that `subdirectory=core` has no Python project metadata). Since the PR body says the full requirements install now succeeds, please update this VCS requirement too, or pin it to a known-good dbt-core tag/release, and rerun the clean install. ########## extension/dbt-doris/dev-requirements.txt: ########## @@ -31,10 +31,11 @@ pre-commit pytest pytest-dotenv pytest-logbook +logbook<1.8 pytest-csv pytest-xdist pytz tox>=3.13 twine wheel -mysql-connector-python>=8.0.0,<8.3 +mysql-connector-python>=8.0.33,<8.3 Review Comment: This range still blocks the dependency-review gate. GitHub flags Connector/Python `<9.1.0` for GHSA-hgjp-83m4-h4fj, and `<8.3` means every version allowed here is below the patched floor; the PR's `dependency-review` job is failing on this line. If the connector floor is also an authentication correctness requirement, note that `setup.py` still permits `mysql-connector-python>=8.0.0` for published installs. Please choose a range that can satisfy the gate or explicitly handle the exception, and align runtime metadata if the floor is meant to be required outside dev. ########## extension/dbt-doris/dev-requirements.txt: ########## @@ -17,7 +17,7 @@ # install latest changes in dbt-core git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core -git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter +git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter Review Comment: This new unpinned `main` dependency currently declares `requires-python = ">=3.10.0"` in `dbt-tests-adapter/pyproject.toml`, but `dbt-doris` still advertises `python_requires=">=3.9"` and tox includes `py39`. A contributor using the supported Python 3.9 dev environment will not be able to install this updated requirement once pip evaluates that package metadata. Please either pin/select a dbt-tests-adapter version that still supports Python 3.9, or update the adapter metadata and tox matrix to require Python 3.10+ in the same change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
