github-actions[bot] commented on code in PR #65337:
URL: https://github.com/apache/doris/pull/65337#discussion_r3551906925
##########
regression-test/suites/compaction/test_base_compaction_no_value.groovy:
##########
@@ -81,6 +81,7 @@ suite("test_base_compaction_no_value", "p2") {
file """${getS3Url()}/regression/tpch/sf1/lineitem.csv.split01.gz"""
time 10000 // limit inflight 10s
+ retryIfHttpError true
Review Comment:
This flag does not take effect in the default cache-enabled regression path.
`prepareHttpEntity` creates `context.config.cacheDataPath` and, when
`enableCacheData` is true, downloads HTTP/S inputs through
`cacheHttpFile(...)`; only the non-cache branch calls `httpGetStream(...)`,
which is where `retryIfHttpError` wraps the URL in `ResumableHttpInputStream`.
Since `enableCacheData` defaults to true and the pipeline configs here only set
`cacheDataPath = "/data/regression/"`, these changed tests will still use the
plain cache downloader on a cache miss and a local file on a cache hit. Please
either make the cache download path honor `retryIfHttpError`, or bypass/disable
the cache for these loads so the new retry flag actually covers the default
suite execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
