github-actions[bot] commented on code in PR #65340:
URL: https://github.com/apache/doris/pull/65340#discussion_r3551549565


##########
regression-test/suites/insert_p0/test_insert_visible_timeout_return_mode.groovy:
##########
@@ -24,10 +25,13 @@ suite("test_insert_visible_timeout_return_mode", 
"nonConcurrent") {
     }
 
     def debugPoint = "PublishVersionDaemon.stop_publish"
-    // Use the configured FE HTTP endpoint so the case also works when SHOW 
FRONTENDS exposes loopback addresses.
-    def feHttpAddress = context.config.feHttpAddress
-    def feHost = feHttpAddress.split(":")[0]
-    def feHttpPort = Integer.parseInt(feHttpAddress.split(":")[1])
+    // PublishVersionDaemon runs on the master FE. Use the configured 
runner-reachable host and master FE ports,
+    // because SHOW FRONTENDS can expose loopback or internal addresses in 
regression deployments.
+    def feHost = context.config.feHttpAddress.split(":")[0]
+    def feHttpPort = getMasterPort()

Review Comment:
   The host part is now runner-reachable, but this still swaps in ports from 
`frontends()`. In the static nonConcurrent/p0 pipeline configs the reachable 
endpoints are `jdbcUrl = jdbc:mysql://172.19.0.2:9131/...` and `feHttpAddress = 
172.19.0.2:8131`, while the FE config does not override 
`query_port`/`http_port`, so `getMasterPort()` reads the FE-advertised defaults 
`9030/8030`. That rebuilds the JDBC URL as `172.19.0.2:9030` and sends the 
debug-point request to `172.19.0.2:8030`, which are not the configured 
runner-facing endpoints. Please resolve the master FE through runner-reachable 
cluster metadata, or keep the configured JDBC/HTTP ports when the discovered 
master corresponds to the configured FE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to