liutang123 opened a new pull request, #65415:
URL: https://github.com/apache/doris/pull/65415
A top-N query that emits a non-order-by column fails on a
**non-light-schema-change** OLAP table (a table created/upgraded with
`light_schema_change = false`, where every column's `uniqueId` is `-1`):
```sql
select id, name from tbl order by createdate desc limit 10;
```
```
ERROR 1105 (HY000): errCode = 2, detailMessage =
[INTERNAL_ERROR]field name is invalid. field=__DORIS_GLOBAL_ROWID_COL__tbl,
field_name_to_index=[...], col_unique_id=2147483647
```
Fix: disable topn lazy materialization for non-light-schema-change OLAP
tables in MaterializeProbeVisitor and fall back to normal topn (the working
two-phase read path). A new helper supportOlapTopnLazyMaterialize()
consolidates the existing AGG_KEYS exclusion with the new light_schema_change
requirement, applied at visitPhysicalOlapScan, visitPhysicalCatalogRelation and
visitPhysicalFilter.
Add regression test topn_lazy_light_schema_change verifying:
- light_schema_change=false: no lazy materialization in the plan, correct
results.
- light_schema_change=true: lazy materialization still applies, correct
results.
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [*] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
