hoshinojyunn opened a new pull request, #65398:
URL: https://github.com/apache/doris/pull/65398
Issue Number: None
Related PR: None
Problem Summary:
File cache statistics already track the remote-read bytes for inverted index
and segment footer
index data, but BE Doris metrics only export the aggregate
cache/local/remote/peer byte counters.
As a result, these two index-specific remote read costs are visible in query
profile internals but
not exposed from the BE `/metrics` endpoint, which makes them harder to
monitor and alert on in
cloud/file-cache scenarios.
This PR exposes the following two BE metrics:
- `doris_be_inverted_index_bytes_read_from_remote`
- `doris_be_segment_footer_index_bytes_read_from_remote`
The change keeps the existing file cache metrics aggregation path and
extends it in three places:
1. Register the two counters in `DorisMetrics`
2. Extend `FileCacheMetrics::AtomicStatistics` and the aggregation/update
path to accumulate them
3. Export them from the existing metrics hook and cover the behavior with a
BE unit test
### Release note
Add two new BE metrics for file cache remote index read bytes:
- `doris_be_inverted_index_bytes_read_from_remote`
- `doris_be_segment_footer_index_bytes_read_from_remote`
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- `./run-be-ut.sh --run
--filter=DorisMetricsTest.*:FileCacheProfileReporterTest.*`
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes.
- The BE `/metrics` endpoint now exports two additional file cache
remote-byte counters for
inverted index and segment footer index reads.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
