github-actions[bot] commented on code in PR #65338: URL: https://github.com/apache/doris/pull/65338#discussion_r3536389027
########## regression-test/suites/tpch_unique_sql_zstd_bucket1_p1/sql/test_left_anti_join_batch_size.sql: ########## @@ -3,14 +3,14 @@ SELECT /*+SEV_VAR(batch_size=3)*/ l1.l_orderkey okey, l1.l_suppkey skey FROM - regression_test_tpch_unique_sql_zstd_bucket1_p0.lineitem l1 + lineitem l1 WHERE Review Comment: Now that this query resolves to the current P1 suite table, it still is not exercising the low-batch path the test name is meant to cover. The hint above is spelled `SEV_VAR`, but the planner only applies session variables for `SET_VAR`/`set_var`; unknown hint names fall through without calling `SelectHintSetVar#setVarOnceInSql`, so `batch_size=3` is ignored and the query runs with the default batch size. Please fix the hint to `SET_VAR(batch_size=3)` while touching this regression so the now-runnable test actually covers the intended left anti join batch-size case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
