github-actions[bot] commented on code in PR #15618: URL: https://github.com/apache/doris/pull/15618#discussion_r1063045157
########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; Review Comment: warning: no member named 'catalog' in 'doris::_TMetadataTableRequestParams__isset' [clang-diagnostic-error] ```cpp meta_table_params.__isset.catalog = true; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, Review Comment: warning: expected unqualified-id [clang-diagnostic-error] ```cpp VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; Review Comment: warning: no member named 'catalog' in 'doris::TMetadataTableRequestParams' [clang-diagnostic-error] ```cpp meta_table_params.catalog = ""; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; + meta_table_params.table = ""; Review Comment: warning: no member named 'table' in 'doris::TMetadataTableRequestParams' [clang-diagnostic-error] ```cpp meta_table_params.table = ""; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; + meta_table_params.table = ""; + meta_table_params.__isset.table = true; Review Comment: warning: no member named 'table' in 'doris::_TMetadataTableRequestParams__isset' [clang-diagnostic-error] ```cpp meta_table_params.__isset.table = true; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; Review Comment: warning: no member named 'database' in 'doris::_TMetadataTableRequestParams__isset' [clang-diagnostic-error] ```cpp meta_table_params.__isset.database = true; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; + meta_table_params.table = ""; + meta_table_params.__isset.table = true; + +// TIcebergMetadataParams iceberg_params = TIcebergMetadataParams(); + iceberg_params.metadata_type = ; Review Comment: warning: use of undeclared identifier 'iceberg_params' [clang-diagnostic-error] ```cpp iceberg_params.metadata_type = ; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; + meta_table_params.table = ""; + meta_table_params.__isset.table = true; + +// TIcebergMetadataParams iceberg_params = TIcebergMetadataParams(); + iceberg_params.metadata_type = ; + iceberg_params.__isset.metadata_type = true; Review Comment: warning: use of undeclared identifier 'iceberg_params' [clang-diagnostic-error] ```cpp iceberg_params.__isset.metadata_type = true; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.h: ########## @@ -0,0 +1,49 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "runtime/runtime_state.h" +#include "vec/exec/scan/vscanner.h" +#include "vmeta_scan_node.h" + +namespace doris::vectorized { + +class VMetaScanner : public VScanner { +public: + VMetaScanner(RuntimeState* state, VMetaScanNode* parent, const TupleId& tuple_id, int64_t limit); + + Status open(RuntimeState* state) override; + Status close(RuntimeState* state) override; + +public: Review Comment: warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers] ```suggestion ``` **be/src/vec/exec/scan/vmeta_scanner.h:26:** previously declared here ```cpp public: ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; Review Comment: warning: no member named 'database' in 'doris::TMetadataTableRequestParams' [clang-diagnostic-error] ```cpp meta_table_params.database = ""; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; + meta_table_params.table = ""; + meta_table_params.__isset.table = true; + +// TIcebergMetadataParams iceberg_params = TIcebergMetadataParams(); + iceberg_params.metadata_type = ; + iceberg_params.__isset.metadata_type = true; + + meta_table_params.iceberg_metadata_params = iceberg_params; Review Comment: warning: use of undeclared identifier 'iceberg_params' [clang-diagnostic-error] ```cpp meta_table_params.iceberg_metadata_params = iceberg_params; ^ ``` ########## be/src/vec/exec/scan/vmeta_scanner.cpp: ########## @@ -0,0 +1,96 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "vmeta_scanner.h" +#include <gen_cpp/FrontendService_types.h> +#include "gen_cpp/FrontendService.h" +#include <gen_cpp/HeartbeatService_types.h> + +#include "runtime/client_cache.h" +#include "util/thrift_rpc_helper.h" + +namespace doris::vectorized { + +VMetaScanner::(RuntimeState* state, VMetaScanNode* parent, const TMetaScanRange& scan_range, + const TupleId& tuple_id, int64_t limit) + : VScanner(state, static_cast<VScanNode*>(parent), limit), _scan_range(scan_range), _tuple_id(tuple_id) { +} + +Status VMetaScanner::open(RuntimeState* state) { + RETURN_IF_ERROR(VScanner::open(state)); + _fetch_metadata_batch(); + return Status::OK(); +} + +Status VMetaScanner::prepare(RuntimeState* state, VExprContext** vconjunct_ctx_ptr) { + return Status::OK(); +} + +Status VMetaScanner::_get_block_impl(RuntimeState* state, Block* block, bool* eof) { + return Status::OK(); +} + +Status VMetaScanner::_fetch_metadata_batch() { + TFetchSchemaTableDataRequest request; + request.cluster_name = ""; + request.__isset.cluster_name = true; + request.schema_table_name = TSchemaTableName::ICEBERG_TABLE_META; + request.__isset.schema_table_name = true; + + TMetadataTableRequestParams meta_table_params = TMetadataTableRequestParams(); + meta_table_params.catalog = ""; + meta_table_params.__isset.catalog = true; + meta_table_params.database = ""; + meta_table_params.__isset.database = true; + meta_table_params.table = ""; + meta_table_params.__isset.table = true; + +// TIcebergMetadataParams iceberg_params = TIcebergMetadataParams(); + iceberg_params.metadata_type = ; Review Comment: warning: expected expression [clang-diagnostic-error] ```cpp iceberg_params.metadata_type = ; ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
