github-actions[bot] commented on code in PR #64923:
URL: https://github.com/apache/doris/pull/64923#discussion_r3523483869
##########
regression-test/suites/query_profile/s3_load_profile_test.groovy:
##########
@@ -139,69 +140,74 @@ PROPERTIES (
)
${prop}
"""
- logger.info("submit sql: ${sql_str}");
- sql """${sql_str}"""
- logger.info("Submit load with lable: $label, table:
$loadAttribute.dataDesc.tableName, path: $loadAttribute.dataDesc.path")
+ logger.info("submit sql: ${sql_str}");
+ sql """${sql_str}"""
+ logger.info("Submit load with lable: $label, table:
$loadAttribute.dataDesc.tableName, path: $loadAttribute.dataDesc.path")
- def max_try_milli_secs = 600000
- def jobId = -1
- while (max_try_milli_secs > 0) {
- String[][] result = sql """ show load where
label="$loadAttribute.label" order by createtime desc limit 1; """
- if (result[0][2].equals("FINISHED")) {
- if (loadAttribute.isExceptFailed) {
- assertTrue(false, "load should be failed but was success:
$result")
+ def max_try_milli_secs = 600000
+ def jobId = -1
+ while (max_try_milli_secs > 0) {
+ String[][] result = sql """ show load where
label="$loadAttribute.label" order by createtime desc limit 1; """
+ if (result[0][2].equals("FINISHED")) {
+ if (loadAttribute.isExceptFailed) {
+ assertTrue(false, "load should be failed but was success:
$result")
+ }
+ jobId = result[0][0].toLong()
+ logger.info("Load FINISHED " + loadAttribute.label + ":
$result" + " loadId: $jobId")
+ break
}
- jobId = result[0][0].toLong()
- logger.info("Load FINISHED " + loadAttribute.label + ": $result" +
" loadId: $jobId")
- break
- }
- if (result[0][2].equals("CANCELLED")) {
- if (loadAttribute.isExceptFailed) {
- logger.info("Load FINISHED " + loadAttribute.label)
+ if (result[0][2].equals("CANCELLED")) {
+ if (loadAttribute.isExceptFailed) {
+ logger.info("Load FINISHED " + loadAttribute.label)
+ break
+ }
+ assertTrue(false, "load failed: $result")
break
}
- assertTrue(false, "load failed: $result")
- break
- }
- Thread.sleep(1000)
- max_try_milli_secs -= 1000
- if (max_try_milli_secs <= 0) {
- assertTrue(false, "load Timeout: $loadAttribute.label")
+ Thread.sleep(1000)
+ max_try_milli_secs -= 1000
+ if (max_try_milli_secs <= 0) {
+ assertTrue(false, "load Timeout: $loadAttribute.label")
+ }
}
- }
- Thread.sleep(500)
- qt_select """ select count(*) from $loadAttribute.dataDesc.tableName """
- logger.info("jobId: " + jobId)
+ Thread.sleep(500)
+ qt_select """ select count(*) from $loadAttribute.dataDesc.tableName
"""
+ logger.info("jobId: " + jobId)
- def allFrontends = sql """show frontends;"""
- logger.info("allFrontends: " + allFrontends)
+ def allFrontends = sql """show frontends;"""
+ logger.info("allFrontends: " + allFrontends)
/*
- allFrontends: [[fe_2457d42b_68ad_43c4_a888_b3558a365be2, 127.0.0.1,
6917, 5937, 6937, 5927, -1, FOLLOWER, true, 1523277282, true, true, 13436,
2025-01-22 16:39:05, 2025-01-22 21:43:49, true, , doris-0.0.0--03faad7da5, Yes]]
*/
- def frontendCounts = allFrontends.size()
- def masterIP = ""
- def masterHTTPPort = ""
+ def frontendCounts = allFrontends.size()
+ def masterIP = ""
+ def masterHTTPPort = ""
- for (def i = 0; i < frontendCounts; i++) {
- def currentFrontend = allFrontends[i]
- def isMaster = currentFrontend[8]
- if (isMaster == "true") {
- masterIP = allFrontends[i][1]
- masterHTTPPort = allFrontends[i][3]
- break
+ for (def i = 0; i < frontendCounts; i++) {
+ def currentFrontend = allFrontends[i]
+ def isMaster = currentFrontend[8]
+ if (isMaster == "true") {
+ masterIP = allFrontends[i][1]
+ masterHTTPPort = allFrontends[i][3]
+ break
+ }
}
- }
- if (masterIP == "" || masterHTTPPort == "") {
- assertTrue(false, "Cannot find master FE from show frontends result:
$allFrontends")
- }
- def masterAddress = masterIP + ":" + masterHTTPPort
- logger.info("masterIP:masterHTTPPort is:${masterAddress}")
+ if (masterIP == "" || masterHTTPPort == "") {
+ assertTrue(false, "Cannot find master FE from show frontends
result: $allFrontends")
+ }
+ def masterAddress = masterIP + ":" + masterHTTPPort
+ logger.info("masterIP:masterHTTPPort is:${masterAddress}")
- def profileString = getProfile(masterAddress, jobId.toString())
- logger.info("profileDataString:" + profileString)
- assertTrue(profileString.contains("NumScanners"))
- assertTrue(profileString.contains("RowsProduced"))
- assertTrue(profileString.contains("RowsRead"))
+ def profileAction = new ProfileAction(context)
+ def profileString = profileAction.waitProfile(
Review Comment:
This still gives the test only a 30s client-side wait even though the suite
just raised `profile_waiting_time_for_spill_seconds` to 60. `waitProfile`
defaults to `DEFAULT_PROFILE_WAIT_TIMEOUT_MS = 30000`, while FE
`Profile.shouldStoreToStorage()` waits up to the configured spill window before
declaring an incomplete profile. A slow profile that finishes after 30s but
before the 60s FE window would now fail this regression even though the FE
behavior is still within the window the test requested. Please pass an explicit
timeout at least as long as the temporary FE config here, and do the same for
the analogous `scanner_profile` default `getProfileBySql` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
