gavinchou commented on PR #64795: URL: https://github.com/apache/doris/pull/64795#issuecomment-4874349273
Follow-up to my previous request-changes review: after offline discussion with the owner, I agree this PR can be merged. The concern I raised is real if we require compatibility with the old TIMESTAMPTZ dynamic-partition boundary behavior. However, that old behavior is the incorrect semantics: dynamic partition boundaries for TIMESTAMPTZ should be generated according to `dynamic_partition.time_zone` and persisted as UTC instants. We agreed that preserving the previous behavior is not a goal for this feature, and known usage does not require keeping the old boundary alignment. So the possible old/new range mismatch is an acceptable upgrade tradeoff rather than a blocker for this fix. The PR moves TIMESTAMPTZ dynamic partitions to the correct behavior for newly generated ranges, and I do not think we need to block the merge on a compatibility marker/migration for the old semantics. I have approved the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
