HappenLee commented on code in PR #64851:
URL: https://github.com/apache/doris/pull/64851#discussion_r3503457542
##########
be/src/exec/runtime_filter/runtime_filter_mgr.cpp:
##########
@@ -428,6 +613,66 @@ Status
RuntimeFilterMergeControllerEntity::_send_rf_to_target(GlobalMergeContext
}
std::vector<TRuntimeFilterTargetParamsV2>& targets = cnt_val.targetv2_info;
+ int timeout_ms = get_execution_rpc_timeout_ms(execution_timeout);
+ apply_request.set_merge_time(merge_time);
+ *apply_request.mutable_query_id() = query_id;
+ const int64_t serialized_filter_size =
+ static_cast<int64_t>(apply_request.ByteSizeLong()) + std::max(0,
len);
+ int fanout = 0;
+ if (query_options.__isset.runtime_filter_tree_publish_max_send_bytes) {
+ int64_t max_send_bytes =
query_options.runtime_filter_tree_publish_max_send_bytes;
+ DORIS_CHECK(max_send_bytes >= 0);
+ fanout = calculate_tree_publish_fanout(serialized_filter_size,
targets.size(),
+ max_send_bytes);
+ }
+ const bool use_tree_publish = fanout > 0 && targets.size() >
static_cast<size_t>(fanout);
Review Comment:
` targets.size() > static_cast<size_t>(fanout);`
这个calculate_tree_publish_fanout本身保证了这个判断一定生效啊？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
