[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15604: [refactor](scan-pool) move scan pool from env to scanner scheduler

[GitBox]

github-actions[bot] commented on code in PR #15604:
URL: https://github.com/apache/doris/pull/15604#discussion_r1062052475


##########
be/test/runtime/test_env.cc:
##########
@@ -36,7 +36,6 @@
     _exec_env->_thread_mgr = new ThreadResourceMgr(2);
     _exec_env->_disk_io_mgr = new DiskIoMgr(1, 1, 1, 10);
     _exec_env->disk_io_mgr()->init(-1);
-    _exec_env->_scan_thread_pool = new PriorityThreadPool(1, 16, "ut_scan");
     _exec_env->_result_queue_mgr = new ResultQueueMgr();

Review Comment:
   warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       _exec_env->_result_queue_mgr = new ResultQueueMgr();
                  ^
   ```
   **be/src/runtime/exec_env.h:211:** declared private here
   ```cpp
       ResultQueueMgr* _result_queue_mgr = nullptr;
                       ^
   ```
   



##########
be/test/runtime/test_env.cc:
##########
@@ -58,7 +57,6 @@
 TestEnv::~TestEnv() {
     SAFE_DELETE(_exec_env->_result_queue_mgr);
     SAFE_DELETE(_exec_env->_buffer_pool);
-    SAFE_DELETE(_exec_env->_scan_thread_pool);
     SAFE_DELETE(_exec_env->_disk_io_mgr);
     SAFE_DELETE(_exec_env->_thread_mgr);

Review Comment:
   warning: '_thread_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       SAFE_DELETE(_exec_env->_thread_mgr);
                              ^
   ```
   **be/src/runtime/exec_env.h:215:** declared private here
   ```cpp
       ThreadResourceMgr* _thread_mgr = nullptr;
                          ^
   ```
   



##########
be/test/runtime/test_env.cc:
##########
@@ -36,7 +36,6 @@ TestEnv::TestEnv() {
     _exec_env->_thread_mgr = new ThreadResourceMgr(2);

Review Comment:
   warning: '_thread_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       _exec_env->_thread_mgr = new ThreadResourceMgr(2);
                  ^
   ```
   **be/src/runtime/exec_env.h:215:** declared private here
   ```cpp
       ThreadResourceMgr* _thread_mgr = nullptr;
                          ^
   ```
   



##########
be/test/runtime/test_env.cc:
##########
@@ -36,7 +36,6 @@
     _exec_env->_thread_mgr = new ThreadResourceMgr(2);
     _exec_env->_disk_io_mgr = new DiskIoMgr(1, 1, 1, 10);

Review Comment:
   warning: '_disk_io_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       _exec_env->_disk_io_mgr = new DiskIoMgr(1, 1, 1, 10);
                  ^
   ```
   **be/src/runtime/exec_env.h:239:** declared private here
   ```cpp
       DiskIoMgr* _disk_io_mgr = nullptr;
                  ^
   ```
   



##########
be/test/runtime/test_env.cc:
##########
@@ -58,7 +57,6 @@
 TestEnv::~TestEnv() {
     SAFE_DELETE(_exec_env->_result_queue_mgr);

Review Comment:
   warning: '_result_queue_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       SAFE_DELETE(_exec_env->_result_queue_mgr);
                              ^
   ```
   **be/src/runtime/exec_env.h:211:** declared private here
   ```cpp
       ResultQueueMgr* _result_queue_mgr = nullptr;
                       ^
   ```
   



##########
be/test/runtime/test_env.cc:
##########
@@ -58,7 +57,6 @@
 TestEnv::~TestEnv() {
     SAFE_DELETE(_exec_env->_result_queue_mgr);
     SAFE_DELETE(_exec_env->_buffer_pool);
-    SAFE_DELETE(_exec_env->_scan_thread_pool);
     SAFE_DELETE(_exec_env->_disk_io_mgr);

Review Comment:
   warning: '_disk_io_mgr' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       SAFE_DELETE(_exec_env->_disk_io_mgr);
                              ^
   ```
   **be/src/runtime/exec_env.h:239:** declared private here
   ```cpp
       DiskIoMgr* _disk_io_mgr = nullptr;
                  ^
   ```
   



##########
be/test/runtime/test_env.cc:
##########
@@ -58,7 +57,6 @@
 TestEnv::~TestEnv() {
     SAFE_DELETE(_exec_env->_result_queue_mgr);
     SAFE_DELETE(_exec_env->_buffer_pool);

Review Comment:
   warning: '_buffer_pool' is a private member of 'doris::ExecEnv' 
[clang-diagnostic-error]
   ```cpp
       SAFE_DELETE(_exec_env->_buffer_pool);
                              ^
   ```
   **be/src/runtime/exec_env.h:250:** declared private here
   ```cpp
       BufferPool* _buffer_pool = nullptr;
                   ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org