morrySnow commented on code in PR #64884:
URL: https://github.com/apache/doris/pull/64884#discussion_r3496903440
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -183,6 +183,7 @@ private Plan
bindOlapTableSink(MatchingContext<UnboundTableSink<Plan>> ctx) {
DatabaseIf database = pair.first;
OlapTable table = pair.second;
boolean isPartialUpdate = sink.isPartialUpdate() &&
table.getKeysType() == KeysType.UNIQUE_KEYS;
+ boolean isDeletePartialUpdate = isPartialUpdate &&
sink.getDMLCommandType() == DMLCommandType.DELETE;
Review Comment:
这个看起来可以作为sink的一个方法，没有必要用参数传递
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
