englefly commented on code in PR #59263:
URL: https://github.com/apache/doris/pull/59263#discussion_r3491989532
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/TopNScanOpt.java:
##########
@@ -60,13 +60,20 @@ boolean checkTopN(TopN topN) {
return false;
}
- Expression firstKey = topN.getOrderKeys().get(0).getExpr();
+ DataType firstKeyType =
topN.getOrderKeys().get(0).getExpr().getDataType();
- if (firstKey.getDataType().isFloatType()
- || firstKey.getDataType().isDoubleType()) {
- return false;
- }
- return true;
+ return isSupportedTopNRuntimeFilterType(firstKeyType);
+ }
+
+ private boolean isSupportedTopNRuntimeFilterType(DataType dataType) {
Review Comment:
pr 合入后,支持的数据类型减少了吗?还说以前有 bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
