airborne12 commented on code in PR #64522:
URL: https://github.com/apache/doris/pull/64522#discussion_r3490861319
##########
fe/fe-core/src/main/java/org/apache/doris/DorisFE.java:
##########
@@ -145,6 +146,11 @@ public static void start(String dorisHomeDir, String
pidDir, String[] args, Star
// Must init custom config after init config, separately.
// Because the path of custom config file is defined in fe.conf
config.initCustom(Config.custom_config_dir + "/fe_custom.conf");
+ if (Config.inverted_index_storage_format.equalsIgnoreCase("V1")) {
Review Comment:
Blocking: this makes an upgraded FE fail to start if operators still have
`inverted_index_storage_format=V1` in `fe.conf` or `fe_custom.conf`. The PR
contract is to block *new* V1 creation while keeping existing V1 metadata
compatible; a startup failure turns a deprecated default into an availability
break. Please allow startup and enforce the ban only when materializing the
effective format for new table/index creation (for example, normalize/reject
`DEFAULT + config=V1` on the DDL path).
##########
regression-test/suites/inverted_index_p0/load/test_stream_load.groovy:
##########
@@ -109,7 +109,9 @@ suite("test_stream_load_with_inverted_index_p0", "p0,
nonConcurrent") {
if (isCloudMode()) {
return;
}
- test.call("V1")
+ setFeConfigTemporary([allow_inverted_index_v1_creation: true]) {
Review Comment:
Blocking/CI: `allow_inverted_index_v1_creation` is not a FE config in this
PR. `setFeConfigTemporary` first reads the old value through `SHOW FRONTEND
CONFIG LIKE`, so this suite fails before `test.call("V1")` runs. If V1
compatibility still needs coverage, use a real isolated legacy fixture/setup;
otherwise change this to an expected deprecation-error case or remove the V1
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
