HappenLee commented on code in PR #15567:
URL: https://github.com/apache/doris/pull/15567#discussion_r1061169926
##########
be/src/vec/exec/join/vnested_loop_join_node.cpp:
##########
@@ -544,7 +545,8 @@ Status
VNestedLoopJoinNode::_do_filtering_and_update_visited_flags(Block* block,
const size_t size = filter.size();
for (size_t i = 0; i < size; ++i) {
- filter_data[i] &= !null_map[i];
+ filter_data[i] = filter_null ? (filter_data[i] || null_map[i])
Review Comment:
the origin code look can simd，make sure the new code is better？
maybe the better way is
```
if(filter_null) {
for ...
} else {
for...
}
```
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -864,6 +864,9 @@ Status HashJoinNode::sink(doris::RuntimeState* state,
vectorized::Block* in_bloc
if (eos || (!_should_build_hash_table && !state->enable_pipeline_exec())) {
_process_hashtable_ctx_variants_init(state);
}
+ if (eos && !_build_blocks->empty() && _is_anti_join) {
Review Comment:
Add a comment here to left other know why do the work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
