github-actions[bot] commented on code in PR #64939:
URL: https://github.com/apache/doris/pull/64939#discussion_r3490118023
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -1669,11 +1669,11 @@ Status CloudMetaMgr::abort_txn(const StreamLoadContext&
ctx) {
AbortTxnResponse res;
req.set_cloud_unique_id(config::cloud_unique_id);
req.set_reason(std::string(ctx.status.msg().substr(0, 1024)));
- if (ctx.db_id > 0 && !ctx.label.empty()) {
+ if (ctx.txn_id > 0) {
Review Comment:
This fixes the production path by changing the wrapper to prefer `txn_id`,
but there still is no test that exercises the field-selection behavior being
changed here. The existing cloud tests call `MetaServiceImpl::abort_txn`
directly with txn-id-only or label-only `AbortTxnRequest`s, so they would still
pass if `CloudMetaMgr::abort_txn` regressed to sending `db_id + label` whenever
both fields are present. Please add a focused test around this wrapper path,
for example a cloud/BE test that builds a `StreamLoadContext` with the old
`txn_id`, `db_id`, and reused label while a newer same-label transaction is
running, then verifies the old txn is targeted and the newer txn is left
un-aborted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
