github-actions[bot] commented on code in PR #64820:
URL: https://github.com/apache/doris/pull/64820#discussion_r3489088339
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/EagerAggRewriter.java:
##########
@@ -18,18 +18,18 @@
package org.apache.doris.nereids.rules.rewrite.eageraggregation;
import org.apache.doris.common.Pair;
-import org.apache.doris.nereids.rules.analysis.NormalizeAggregate;
import org.apache.doris.nereids.rules.rewrite.StatsDerive;
import
org.apache.doris.nereids.rules.rewrite.eageraggregation.EagerAggHints.Action;
import org.apache.doris.nereids.stats.ExpressionEstimation;
import org.apache.doris.nereids.trees.expressions.Alias;
-import org.apache.doris.nereids.trees.expressions.CaseWhen;
import org.apache.doris.nereids.trees.expressions.Cast;
import org.apache.doris.nereids.trees.expressions.ExprId;
import org.apache.doris.nereids.trees.expressions.Expression;
import org.apache.doris.nereids.trees.expressions.IsNull;
import org.apache.doris.nereids.trees.expressions.Multiply;
import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.NullToNonNullFunction;
+import org.apache.doris.nereids.trees.expressions.functions.AlwaysNotNullable;
Review Comment:
FE checkstyle sorts imports alphabetically inside the Doris import group.
This new `functions.AlwaysNotNullable` import currently appears before
`Slot`/`SlotReference`, so the checkstyle gate should still fail here. Please
move it below `SlotReference`, matching the ordering already used in
`PushDownAggregation.java`.
##########
fe/fe-core/src/test/java/org/apache/doris/nereids/rules/rewrite/eageraggregation/EagerAggRewriterTest.java:
##########
@@ -551,6 +551,198 @@ void
testUniqueFunctionFilterBlocksPushDownThroughFilter() {
}
}
+ //
=========================================================================
Review Comment:
The later `AlwaysNotNullable` fallback that fixes the
`array(nullable_side_col)` case is still untested here. The new cases exercise
explicit marker functions (`IsNull`, `NullSafeEqual`, `Coalesce`, `Nvl`,
`NullOrEmpty`, `NotNullOrEmpty`), but they would keep passing if the broad `e
instanceof AlwaysNotNullable && !getInputSlots().isEmpty()` branch were removed
or broken. Since the existing code review thread for this PR called out
`count(array(t2.name))` as the concrete remaining wrong-result shape, please
add a plan-shape regression for that path too, for example
`count(array(t2.name))` on the nullable side of a left/right outer join and
assert no `LogicalAggregate` is pushed under that nullable side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
