yiguolei commented on code in PR #63389:
URL: https://github.com/apache/doris/pull/63389#discussion_r3451683289
##########
be/src/format/parquet/vparquet_reader.cpp:
##########
@@ -1065,6 +1077,43 @@ void
ParquetReader::set_condition_cache_context(std::shared_ptr<ConditionCacheCo
}
}
+bool ParquetReader::_expr_zonemap_page_slot_index(const VExprContextSPtr&
conjunct,
+ int* cid) const {
+ DORIS_CHECK(cid != nullptr);
+ if (conjunct == nullptr || conjunct->root() == nullptr ||
+ !conjunct->root()->can_evaluate_zonemap_filter()) {
+ return false;
+ }
+
+ std::set<int> column_ids;
+ conjunct->root()->collect_slot_column_ids(column_ids);
+ if (column_ids.size() != 1) {
+ return false;
+ }
+
+ const int slot_index = *column_ids.begin();
+ if (slot_index < 0 || static_cast<size_t>(slot_index) >=
_tuple_descriptor->slots().size()) {
+ return false;
+ }
+ auto* slot = _tuple_descriptor->slots()[slot_index];
+ if (!_exists_in_file(slot->col_name()) || !_type_matches(slot_index)) {
Review Comment:
如果做过rename 操作，这个slot name 应该是新名字，那么老的parquet 文件里，还是老名字怎么办？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
