liaoxin01 commented on code in PR #15481:
URL: https://github.com/apache/doris/pull/15481#discussion_r1059255115
##########
be/src/olap/rowset/segment_v2/binary_prefix_page.cpp:
##########
@@ -257,21 +257,23 @@ Status BinaryPrefixPageDecoder::next_batch(size_t* n,
ColumnBlockView* dst) {
RETURN_IF_ERROR(_copy_current_to_output(dst->pool(), out));
i++;
out++;
+ _cur_pos++;
// read and copy remaining values
for (; i < max_fetch; ++i) {
- _cur_pos++;
RETURN_IF_ERROR(_read_next_value_to_output(prev[i - 1], dst->pool(),
out));
out++;
+ _cur_pos++;
}
//must update _current_value
_current_value.clear();
_current_value.assign_copy((uint8_t*)prev[i - 1].data, prev[i - 1].size);
Review Comment:
It is needed. _read_next_value needs to know the previous value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
