github-actions[bot] commented on code in PR #64562:
URL: https://github.com/apache/doris/pull/64562#discussion_r3449733727
##########
regression-test/suites/load_p2/tvf/test_s3_tvf.groovy:
##########
@@ -935,8 +929,10 @@ suite("test_s3_tvf", "p2") {
Review Comment:
This still only validates the `expectFiled` cases when an exception is
thrown. If one of the negative TVF attributes unexpectedly succeeds, execution
skips this catch block and the loop continues to `qt_select`, so the test no
longer proves that the malformed-file cases fail. Please add an explicit
success-path failure after `sql` when `attribute.expectFiled` is true, or split
these cases into the standard `test { sql ...; exception ... }` pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
