github-actions[bot] commented on code in PR #64577: URL: https://github.com/apache/doris/pull/64577#discussion_r3427731348
########## regression-test/data/function_p0/cast/to_string/from_float/test_cast_to_string_from_float.out: ########## @@ -232,10 +232,10 @@ NaN NaN NaN 1234567890123456.12345 1.234567890123456E15 1234567890123456 -- !sql_double_be -- -12345678901234567.12345 1.234567890123457E16 1.234567890123457e+16 +12345678901234567.12345 1.2345678901234568E16 1.2345678901234568e+16 Review Comment: This generated output is still missing one value affected by the formatter change. The same suite already covers `1234567890000.12345` twice, in `sql_double_be` and in `sql_double_to_string`; the checked-in file still expects the old cast string `1234567890000.124` at current file lines 175 and 284. This PR changes the same BE formatter expectation to `1234567890000.1235` in `be/test/exprs/function/cast/cast_to_string.cpp` and `be/test/storage/olap_type_test.cpp`, and `Double.toString(1234567890000.12345)` also preserves `1234567890000.1235`, so rerunning `test_cast_to_string_from_float` will produce `.1235` for both rows and fail against the stale `.124` expectations. Please regenerate/update those two rows too. This is a distinct remaining expected-result file, not the BE/storage unit-test paths already covered by the existing review threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
