morrySnow commented on code in PR #64521:
URL: https://github.com/apache/doris/pull/64521#discussion_r3412006609
##########
be/test/exprs/aggregate/vec_retention_test.cpp:
##########
@@ -293,4 +295,19 @@ TEST_F(VRetentionTest, testSerialize) {
agg_function->destroy(place2);
agg_function->destroy(place3);
}
+
+TEST_F(VRetentionTest, testMaxEventsBoundary) {
+ AggregateFunctionSimpleFactory factory =
AggregateFunctionSimpleFactory::instance();
+
+ // 32 boolean params is the maximum allowed (RetentionState::MAX_EVENTS)
and must succeed.
+ DataTypes max_types(RetentionState::MAX_EVENTS,
std::make_shared<DataTypeUInt8>());
+ auto fn = factory.get("retention", max_types, nullptr, false, -1);
+ EXPECT_NE(fn, nullptr);
+
+ // 33 boolean params overflow the fixed-size events[32] array; the
function must be rejected
+ // at construction time instead of corrupting the heap (CIR-20638).
Review Comment:
remove CIR-20638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
