github-actions[bot] commented on code in PR #63729:
URL: https://github.com/apache/doris/pull/63729#discussion_r3403535724
##########
regression-test/suites/autobucket/test_autobucket.groovy:
##########
@@ -84,7 +84,7 @@ suite("test_autobucket") {
result = sql_return_maparray "show partitions from
autobucket_test_max_buckets"
logger.info("${result}")
// XXX: buckets at pos(8), next maybe impl by sql meta
- assertEquals(1, Integer.valueOf(result.get(0).Buckets)) //equals max bucket
Review Comment:
Setting only `autobucket_max_buckets` to `1` used to cap auto-bucket tables
at 1 bucket, and the config comments still describe this as the maximum. With
the new default minimum of 3, this test now expects 3 after setting max to 1
because `AutoBucketUtils.getBucketsNum(partitionSize, min)` applies
`Math.max(min, buckets)` after `getBucketsNum()` has already clamped to max.
That means a user who lowers `autobucket_max_buckets` below 3 no longer gets
the requested cap unless they also know to lower `autobucket_min_buckets`.
Please either keep the max as a hard cap/validate `max >= min`, or make this
test set min to 1 for the max-cap case if the intended behavior is that min
wins, and update the config docs accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
