github-actions[bot] commented on code in PR #64439:
URL: https://github.com/apache/doris/pull/64439#discussion_r3400408975
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/EnvFactory.java:
##########
@@ -156,7 +156,7 @@ public Coordinator createCoordinator(ConnectContext
context, Planner planner,
if (planner instanceof NereidsPlanner &&
SessionVariable.canUseNereidsDistributePlanner(context)) {
return new NereidsCoordinator(context, (NereidsPlanner) planner,
statsErrorEstimator, jobId);
}
- return new Coordinator(context, planner, statsErrorEstimator);
+ return new Coordinator(context, planner, statsErrorEstimator, jobId);
Review Comment:
This fixes the fallback coordinator path, but the PR does not add coverage
for the actual regression: a labeled `INSERT INTO ... SELECT` submitted through
a follower FE and then checked via `SHOW LOAD`. The existing
`regression-test/suites/load_p0/insert/test_insert_from_follower.groovy`
already starts a 3-FE docker cluster and connects to a follower, but it only
inserts literal values and drops the table. Please extend that suite (or add an
equivalent docker regression) to run a follower-submitted `INSERT INTO target
WITH LABEL ... SELECT ...` and assert that `SHOW LOAD` for the label has
non-empty/non-zero `JobDetails` such as `ScannedRows`, `LoadBytes`, and
backend/task information. Without this, the proxy path can regress while the
existing non-forwarded `test_insert_statistic` still passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
