zhannngchen commented on code in PR #15413:
URL: https://github.com/apache/doris/pull/15413#discussion_r1058029664
##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -166,6 +167,59 @@ class SegmentIterator : public RowwiseIterator {
void _update_max_row(const vectorized::Block* block);
+ // todo(wb) remove this method after RowCursor is removed
+ void _convert_rowcursor_to_short_key(const RowCursor& key, size_t
num_keys) {
Review Comment:
num_keys -> num_key_cols
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
