zclllyybb commented on code in PR #64164: URL: https://github.com/apache/doris/pull/64164#discussion_r3370917955
########## be/src/util/debug/leak_annotations.h: ########## @@ -22,13 +22,20 @@ #define ANNOTATE_LEAKING_OBJECT_PTR(p) #if defined(__has_feature) -#if __has_feature(address_sanitizer) +#if __has_feature(address_sanitizer) || __has_feature(leak_sanitizer) #if defined(__linux__) #undef ANNOTATE_LEAKING_OBJECT_PTR #define ANNOTATE_LEAKING_OBJECT_PTR(p) __lsan_ignore_object(p); #endif +#endif +#elif defined(ADDRESS_SANITIZER) || defined(LEAK_SANITIZER) Review Comment: why `elif`? seems could use `||` to combine into L25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
