BiteTheDDDDt commented on PR #64010: URL: https://github.com/apache/doris/pull/64010#issuecomment-4630643169
Addressed the latest review comments in ca7a3b046f1: - Centralized `_schema_block_id_map` initialization and removed the duplicate initialization from lazy materialization init. - Added a fast path so project-block construction reuses the original block when the project schema is identical to the reader schema. - Reused one project block during virtual column materialization instead of rebuilding it for every virtual column expression, and synced newly materialized virtual columns back into the project block. - Wrapped the virtual-column raw `execute_column()` call with `RETURN_IF_CATCH_EXCEPTION` so expression exceptions are still converted to `Status` at this boundary. Validation: - `./build.sh --be`: passed. - `build-support/run-clang-tidy.sh`: attempted; it reports existing analysis diagnostics in `segment_iterator.cpp`, `segment_iterator.h`, and `be/src/util/jni-util.h` unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
