Tanya-W commented on code in PR #13035: URL: https://github.com/apache/doris/pull/13035#discussion_r1057175851
########## be/src/olap/rowset/segment_v2/segment_iterator.h: ########## @@ -226,6 +250,10 @@ class SegmentIterator : public RowwiseIterator { StorageReadOptions _opts; // make a copy of `_opts.column_predicates` in order to make local changes std::vector<ColumnPredicate*> _col_predicates; + std::vector<ColumnPredicate*> _all_compound_col_predicates; Review Comment: rename to `_col_preds_except_leafnode_of_andnode`, the difference with `_col_predicates` is those predicates are not leaf node of AND node in `conjunct_expr_root`, _col_preds_except_leafnode_of_andnode's predicates although pushed down, still remain in the `conjunct_expr_root` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org