github-actions[bot] commented on code in PR #15358:
URL: https://github.com/apache/doris/pull/15358#discussion_r1057081742
##########
be/src/vec/exec/format/parquet/vparquet_group_reader.cpp:
##########
@@ -57,7 +57,7 @@ Status RowGroupReader::init(const FieldDescriptor& schema,
std::vector<RowRange>
for (auto& read_col : _read_columns) {
auto field =
const_cast<FieldSchema*>(schema.get_column(read_col._file_slot_name));
std::unique_ptr<ParquetColumnReader> reader;
- RETURN_IF_ERROR(ParquetColumnReader::create(_file_reader, field,
read_col, _row_group_meta,
+ RETURN_IF_ERROR(ParquetColumnReader::create(_file_reader, field,
_row_group_meta,
Review Comment:
warning: no viable conversion from 'io::FileReaderSPtr' (aka
'shared_ptr<doris::io::FileReader>') to 'doris::FileReader *'
[clang-diagnostic-error]
```cpp
RETURN_IF_ERROR(ParquetColumnReader::create(_file_reader, field,
_row_group_meta,
^
```
**be/src/common/status.h:484:** expanded from macro 'RETURN_IF_ERROR'
```cpp
Status _status_ = (stmt); \
^
```
**be/src/vec/exec/format/parquet/vparquet_column_reader.h:109:** passing
argument to parameter 'file' here
```cpp
static Status create(FileReader* file, FieldSchema* field, const
tparquet::RowGroup& row_group,
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
